Merged
Conversation
There was a rebasing mistake on a previous commit as I created some exclusions but their name was changed before payjoin#910 was merged and they were not caught. There is one exclusion that is simply renamed but another I decided to change the logic such that the exclusions are no longer possible.
benalleng
force-pushed
the
wants-fee-mutants
branch
from
bfb36ab to
33903ba
Compare
spacebear21
approved these changes
Aug 4, 2025
Collaborator
spacebear21
left a comment
spacebear21
left a comment
There was a problem hiding this comment.
ACK 33903ba, the logic change in apply_fee makes a lot of sense. I'd prefer separate commits for the renamed exclusion + logic change but will merge this as-is.
Collaborator
Author
|
RIP I had squashed them into one commit earlier |
Collaborator
Pull Request Test Coverage Report for Build 16700379761Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #917
There were some stale exclusions before #910 was merged, hopefully that PR minimizes as many PRs like this one as possible.
I simply renamed the exclusion for one but decided to try and change the logic to try and prevent a mutant in another