Skip to content

Restore original psbt output fields#909

Merged
spacebear21 merged 1 commit intopayjoin:masterfrom
arminsabouri:restore-psbt-outputs
Jul 30, 2025
Merged

Restore original psbt output fields#909
spacebear21 merged 1 commit intopayjoin:masterfrom
arminsabouri:restore-psbt-outputs

Conversation

@arminsabouri
Copy link
Collaborator

BIP78 spec requires output fields to be pruned, but many wallets require the output fields to be present in order to validate change and payment outputs.

Related ticket: #906

BIP78 spec requires output fields to be pruned, but many wallets
require the output fields to be present in order to validate change
and payment outputs.
@arminsabouri arminsabouri requested a review from spacebear21 July 30, 2025 15:13
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 16626544963

Details

  • 50 of 50 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 86.002%

Totals Coverage Status
Change from base Build 16626389807: 0.08%
Covered Lines: 7993
Relevant Lines: 9294

💛 - Coveralls

Copy link
Collaborator

@spacebear21 spacebear21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 62c18c2

@spacebear21 spacebear21 merged commit f3ded25 into payjoin:master Jul 30, 2025
9 checks passed
@arminsabouri arminsabouri deleted the restore-psbt-outputs branch July 30, 2025 16:10
@arminsabouri arminsabouri restored the restore-psbt-outputs branch July 30, 2025 17:16
@arminsabouri arminsabouri deleted the restore-psbt-outputs branch July 30, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants