Skip to content

Add Feature Request, Good First Issue, and General Issue Templates#891

Merged
DanGould merged 1 commit intopayjoin:masterfrom
thebrandonlucas:remaining-issue-templates
Jul 22, 2025
Merged

Add Feature Request, Good First Issue, and General Issue Templates#891
DanGould merged 1 commit intopayjoin:masterfrom
thebrandonlucas:remaining-issue-templates

Conversation

@thebrandonlucas
Copy link
Collaborator

@thebrandonlucas thebrandonlucas commented Jul 21, 2025

Followup to #758. Adds the following issue templates mostly from their Bitcoin Core counterparts (excepting the "General" template):

It would probably be prudent for us to add SECURITY.md as well, but I'd need clarity on if we want to follow the pattern Bitcoin Core has established, and if so, which contributors should be contacted when reporting vulnerabilities and what methods of contact would be best (i.e. should we use a security issues dedicated email & PGP keys for contributors to whom issues can be reported).

Upon receiving that information if we would like to do this I will create SECURITY.md in a subsequent PR.

@thebrandonlucas thebrandonlucas force-pushed the remaining-issue-templates branch from 115da4f to aa0e3bb Compare July 21, 2025 15:47
@coveralls
Copy link
Collaborator

coveralls commented Jul 21, 2025

Pull Request Test Coverage Report for Build 16446746855

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.706%

Totals Coverage Status
Change from base Build 16427048792: 0.0%
Covered Lines: 7741
Relevant Lines: 9032

💛 - Coveralls

Copy link
Contributor

@DanGould DanGould left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this but feel the dropdown needs a slight fix across all 3 templates

@thebrandonlucas thebrandonlucas force-pushed the remaining-issue-templates branch from aa0e3bb to d379ae0 Compare July 22, 2025 14:05
- [x] Add feature-request.yml to ISSUE_TEMPLATES

- [x] Add good first issue template

- [x] Add general issue template

      Not all issues fit into one of our available templates (bug,
      feature request, good first issue, etc.), this issue template
      accounts for that.
@thebrandonlucas thebrandonlucas force-pushed the remaining-issue-templates branch from d379ae0 to 29f5910 Compare July 22, 2025 14:08
@thebrandonlucas
Copy link
Collaborator Author

@DanGould thanks for that catch, applied the two fixes (set multiple: true and add the payjoin crate) across all 3 dropdowns

Copy link
Contributor

@DanGould DanGould left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 29f5910

@DanGould DanGould merged commit e4badaa into payjoin:master Jul 22, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants