Skip to content

Add mutant catch for incompatible mixed fragment #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nothingmuch merged 1 commit into from
Jul 11, 2025
Merged

Add mutant catch for incompatible mixed fragment #871

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion payjoin/src/core/uri/url_ext.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,7 @@ mod tests {
}

#[test]
fn test_fragment_delimeter_backwards_compatibility() {
fn test_fragment_delimiter_backwards_compatibility() {
// ensure + is still accepted as a delimiter
let uri = "bitcoin:12c6DSiU4Rq3P4ZxziKxzrL5LmMBrzjrJX?amount=0.01\
&pjos=0&pj=HTTPS://EXAMPLE.COM/\
Expand Down Expand Up @@ -513,4 +513,15 @@ mod tests {
Some("EX1C4UC6ES-OH1QYPM5JXYNS754Y4R45QWE336QFX6ZR8DQGVQCULVZTV20TFVEYDMFQC")
);
}

#[test]
fn test_fragment_mixed_delimiter() {
// mixing current and deprecated delimiters should fail
let fragment = "23RK1QG2RH36X9ZWRK\
7UWCCQE0WD8T89XKK2W55KTK9UHSZLEG8Q2TGEGG-OH1QYP87E2AVMDKXDTU6R25WCPQ5ZUF02XHNPA65JMD8ZA2W4YRQN6UUWG+EX1XPK8Y6Q";
assert!(matches!(
check_fragment_delimiter(fragment),
Err(ParseFragmentError::AmbiguousDelimiter)
));
}
}