Remove python-bitcoinlib dependency for ffi#849
Merged
spacebear21 merged 1 commit intopayjoin:masterfrom Jul 3, 2025
Merged
Conversation
We do not have a need for the python-bitcoinlib package as we use it for imports that we already have access to in our payjoin_ffi source.
Collaborator
Pull Request Test Coverage Report for Build 16057803672Details
💛 - Coveralls |
spacebear21
approved these changes
Jul 3, 2025
Collaborator
spacebear21
left a comment
spacebear21
left a comment
There was a problem hiding this comment.
nice and clean, ACK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do not have a need for the python-bitcoinlib package as we use it for imports that we already have access to in our payjoin_ffi source.