Remove to/from json methods on typestates#835
Conversation
Now that we have proper session peristance in [0.24](https://github.com/payjoin/rust-payjoin/releases/tag/payjoin-0.24.0) we should remove these one off to from json method as to descourage devs from creating their own peristance strategies. Resolves payjoin#834
Pull Request Test Coverage Report for Build 16002687643Details
💛 - Coveralls |
spacebear21
left a comment
There was a problem hiding this comment.
code ACK.
To confirm my understanding: the session persister uses JSON internally when calling save/load? So implementers would provide e.g. a k/v store or SQL table with a JSON value column and the session persister would take care of de/serialization?
Yes, this is correct. More accurately the UniFFI exported Json Persister abstract class uses JSON internally in the save and load methods. We could also export other abstract classes that use different encodings (bincode, cbor, etc...) |
Now that we have proper session peristance in
0.24 we should remove these one off to/from json method as to descourage devs from creating their own custom peristance strategies.
Resolves #834