Deduplicate payjoin URI creation logic#817
Merged
spacebear21 merged 1 commit intopayjoin:masterfrom Jun 27, 2025
Merged
Conversation
Create a helper function `create_pj_uri` in the v2 module that centralizes the logic for creating Payjoin URIs from a SessionContext. This eliminates code duplication between `SessionHistory::pj_uri` and `Receiver<WithContext>::pj_uri`. The helper function takes a SessionContext reference and an OutputSubstitution parameter, making it flexible for both use cases while maintaining the same behavior as the original implementations. This change: - Improves maintainability by centralizing URI creation logic - Reduces code duplication - Preserves the existing API and behavior
Collaborator
Author
|
Moved from #812 which was accidentally closed. Merging based on ACKs received there. |
Collaborator
Pull Request Test Coverage Report for Build 15935262286Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a helper function
create_pj_uriin the v2 module that centralizes the logic for creating Payjoin URIs from a SessionContext. This eliminates code duplication betweenSessionHistory::pj_uriandReceiver<WithContext>::pj_uri.The helper function takes a SessionContext reference and an OutputSubstitution parameter, making it flexible for both use cases while maintaining the same behavior as the original implementations.
This change: