Skip to content

Sender session history fallback#805

Merged
arminsabouri merged 4 commits intopayjoin:masterfrom
arminsabouri:sender-session-history-fallback
Jun 25, 2025
Merged

Sender session history fallback#805
arminsabouri merged 4 commits intopayjoin:masterfrom
arminsabouri:sender-session-history-fallback

Conversation

@arminsabouri
Copy link
Collaborator

Extract the unchecked transaction from the original psbt which becomes asccessible in the first session event -- withReplyKey.

@arminsabouri arminsabouri requested a review from spacebear21 June 25, 2025 11:26
@coveralls
Copy link
Collaborator

coveralls commented Jun 25, 2025

Pull Request Test Coverage Report for Build 15884120414

Details

  • 45 of 46 (97.83%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 86.155%

Changes Missing Coverage Covered Lines Changed/Added Lines %
payjoin/src/send/v2/session.rs 45 46 97.83%
Files with Coverage Reduction New Missed Lines %
payjoin/src/send/v2/session.rs 1 86.67%
Totals Coverage Status
Change from base Build 15881414136: 0.05%
Covered Lines: 7909
Relevant Lines: 9180

💛 - Coveralls

Copy link
Collaborator

@spacebear21 spacebear21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test mirroring this one?

Extract the unchecked transaction from the original psbt which
becomes asccessible in the first session event -- withReplyKey.
The session endpoint can be pulled off an earlier event.
This commit adds test coverage for sesssion event replays and the
session history object produced by replaying the logs. The tests persist
session event logs and replay them to verify that the resulting state
matches the expected state.
@arminsabouri arminsabouri force-pushed the sender-session-history-fallback branch from eda751d to 4c17ab6 Compare June 25, 2025 18:23
@arminsabouri arminsabouri requested a review from spacebear21 June 25, 2025 18:34
Copy link
Collaborator

@spacebear21 spacebear21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4c17ab6

@arminsabouri arminsabouri merged commit ab142b3 into payjoin:master Jun 25, 2025
13 checks passed
@arminsabouri arminsabouri deleted the sender-session-history-fallback branch June 25, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants