Fix import of OutputSubstition in send::v2 test

[DanGould]

It is used in v2 tests but only exported at root with v1 feature

problem line:

rust-payjoin/payjoin/src/send/v2/session.rs

Line 98 in b7491be

use crate::{HpkeKeyPair, OutputSubstitution};

[coveralls]

Pull Request Test Coverage Report for Build 15862177983

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 86.011%

---

Totals
Change from base Build 15861266504:	0.0%
Covered Lines:	7815
Relevant Lines:	9086

---

💛 - Coveralls

[spacebear21]

When does the problem occur? You linked to the problem line but output_substitution is already pub(crate) so this shouldn't be a problem?

rust-payjoin/payjoin/src/lib.rs

Line 60 in b7491be

pub(crate) mod output_substitution;

[DanGould]

it's pub crate but only accessible by crate::output_substitution::OutputSubstitution, not crate::OutputSubstitution

[DanGould]

it occurs when payjoin/v2 is enabled but not payjoin/v1

[spacebear21]

Ok I see now. How come CI didn't catch that? As simple as cargo test send to reproduce the failure locally on latest master.

[spacebear21]

Oh, CI just runs with --all-features. Am I misremembering that we had changed it to run with individual features at some point?

[spacebear21]

utACK

[spacebear21]

We may want to follow up with a cleanup in places that currently use crate::output_substitution::OutputSubstitution

[DanGould]

it might make sense for me to just fully qualify that problem line since that sort of makes it more clear that it's internal; doesn't really need to be pub in that case since it's in internal use for testing.

And then we don't need another cleanup.