Merged
Conversation
arminsabouri
force-pushed
the
sender-session-events
branch
from
e81f939 to
1d7b49d
Compare
Collaborator
Pull Request Test Coverage Report for Build 15714751264Details
💛 - Coveralls |
spacebear21
approved these changes
Jun 17, 2025
Collaborator
There was a problem hiding this comment.
Should this file be renamed to session.rs as well to mirror receive?
Collaborator
Author
There was a problem hiding this comment.
Could do. Perhaps in a seperate PR?
arminsabouri
force-pushed
the
sender-session-events
branch
from
1d7b49d to
7e9ac72
Compare
Collaborator
Author
|
Last push exports to and from json methods for uniffi |
This commit adds session events generated by processing the sender state machine. To enable serialization and deserialization of session events, we implement `serde::Serialize` and `serde::Deserialize` on the underlying v1 & v2 types that are captured in session events. To enable comparisons between `SessionEvents` during tests, all event types must also implement `PartialEq` and `Eq`. Tests cover roundtrip ser/deserialization of each session event. All of our uniffi exports are under the same namespace (see payjoin_ffi.udl). This commit adds a sender/reciever name prefix to the exported session event object avoid a naming conflict. [Related ticket](payjoin#723)
arminsabouri
force-pushed
the
sender-session-events
branch
from
79142e8 to
54302e9
Compare
spacebear21
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds session events generated by processing the sender state machine. To enable serialization and deserialization of session events, we implement
serde::Serializeandserde::Deserializeon the underlying v1 & v2 types that are captured in session events.To enable comparisons between
SessionEventsduring tests, all event types must also implementPartialEqandEq.Tests cover roundtrip ser/deserialization of each session event.