Combine test_output_substitution with sender checklist test for clarity#767
Merged
spacebear21 merged 1 commit intopayjoin:masterfrom Jun 13, 2025
Merged
Conversation
Collaborator
Pull Request Test Coverage Report for Build 15640623353Details
💛 - Coveralls |
spacebear21
reviewed
Jun 13, 2025
spacebear21
reviewed
Jun 13, 2025
By combining the test_output_substitution test and test_process_proposal_when_payee_output_has_disallowed_output_substitution we can deduplicate some test logic and ensure that these tests cover all of the checklist test vectors.
benalleng
force-pushed
the
output-substitution-checklist
branch
from
ed3a0d3 to
3b5c485
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By combining the
test_output_substitutiontest andtest_process_proposal_when_payee_output_has_disallowed_output_substitutionwe can de-duplicate some test logic and ensure that these tests cover all of the checklist test vectors.Hopefully we can get all the checks completed in our checklist with these.