Skip to content

Lock cargo mutants version to 25.0.1#759

Merged
spacebear21 merged 1 commit intopayjoin:masterfrom
benalleng:mutants-out-cleanup
Jun 10, 2025
Merged

Lock cargo mutants version to 25.0.1#759
spacebear21 merged 1 commit intopayjoin:masterfrom
benalleng:mutants-out-cleanup

Conversation

@benalleng
Copy link
Collaborator

The new version of cargo mutants introduced a set of new mutants that ultimately is not worth the added effort to fix at the moment as well as introducing some breaking changes that have not been clarified yet how to work around them. For now I am locking the cargo mutants version until we have more clarity on the stability of the mutants workflow and we can put more priority into full mutation coverage.

This should resolve the mutants found in #752 for now. However, as we move up to future versions we will need to get coverage for these eventually.

@coveralls
Copy link
Collaborator

coveralls commented Jun 10, 2025

Pull Request Test Coverage Report for Build 15568609209

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.474%

Totals Coverage Status
Change from base Build 15546580180: 0.0%
Covered Lines: 6973
Relevant Lines: 8158

💛 - Coveralls

@benalleng
Copy link
Collaborator Author

I am currently running a workflow on my branch to make sure that it works as expected. (this workflow is before the version lock, just adds version printing and code block markdown)

@benalleng benalleng force-pushed the mutants-out-cleanup branch from 18e64aa to b22cbb1 Compare June 10, 2025 19:32
The new version of cargo mutants introduced a set of new mutants that
ultimately is not worth the added effort to fix at the moment as well as
introducing some breaking changes that have not been clarified yet how
to work around them. For now I am locking the cargo mutants version
until we have more clarity on the stability of the mutants workflow and
we can put more priority into full mutation coverage.
@benalleng benalleng force-pushed the mutants-out-cleanup branch from b22cbb1 to c008bdb Compare June 10, 2025 19:33
@spacebear21 spacebear21 merged commit aad4c0f into payjoin:master Jun 10, 2025
7 checks passed
@spacebear21 spacebear21 mentioned this pull request Jun 12, 2025
spacebear21 added a commit that referenced this pull request Jun 16, 2025
Corrects the incorrect syntax introduced in #759
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants