Conversation
810e60b to
50adab6
Compare
spacebear21
left a comment
There was a problem hiding this comment.
This is looking good! There are just two changes that need to be made to remove core from the public API and reduce the diff by making the uri module `pub(crate).
Additionally once you've applied those changes, can you ensure you've run cargo fmt to enforce sorting/grouping of imports?
Lastly, the commit message should be updated to reflect the change as a whole and follow the seven rules (specifically rule 7 in this case).
b74a427 to
168eef1
Compare
There was a problem hiding this comment.
There are formatting changes that appear unrelated to the PR. Are you using the nightly rust toolchain (per https://github.com/payjoin/rust-payjoin?tab=readme-ov-file#code-formatting)?
$ rustup default nightly
$ cargo fmt
|
@zealsham beware this PR is super useful tech debt payback but the floor is lava because of the SesssionEventLog persister changes; the timing is gonna have to line up really well with the other PRs and it's going to require some periodic rebasing this week |
|
@spacebear21 yes , it was formated using rustup on nightly build . |
|
Thanks for the heads-up Dan, I’ll keep an eye on the related PRs and make sure to rebase as needed to keep everything aligned. |
Hmm. I don't get those formatting changes if i run I'm on: |
|
rustup 1.28.2 (e4f3ad6f8 2025-04-28) |
168eef1 to
dd2f01c
Compare
Pull Request Test Coverage Report for Build 15949260878Details
💛 - Coveralls |
dd2f01c to
1d5a4bf
Compare
This commit addresses payjoin#688. Co-authored-by: zealsham <shammahagwor@gmail.com>
1d5a4bf to
0a7fdca
Compare
|
Rebased and removed the unrelated formatting changes. |
Rebased and removed the unrelated formatting changes.
After payjoin#746 was merged a small path discrepency was created with the core module now being the direct path to all the src modules. This Pr simply adds core/ into the path so that cargo mutants has the correct path to find those modules.
After #746 was merged a small path discrepancy was created with the core module now being the direct path to all the src modules. This Pr simply adds core/ into the path so that cargo mutants has the correct path to find those modules.
After payjoin#746 was merged a small path discrepency was created with the core module now being the direct path to all the src modules. This Pr simply adds core/ into the path so that cargo mutants has the correct path to find those modules.
After payjoin#746 was merged a small path discrepency was created with the core module now being the direct path to all the src modules. This Pr simply adds core/ into the path so that cargo mutants has the correct path to find those modules.
This pull request resolves 688 , by moving reexports to the
coremodule which gives us a cleaner lib.rs file .This pr also implements the comment by Dan for the core modules.