Skip to content

Clean up re-exports#746

Merged
spacebear21 merged 1 commit intopayjoin:masterfrom
zealsham:fix-core-module-export
Jun 28, 2025
Merged

Clean up re-exports#746
spacebear21 merged 1 commit intopayjoin:masterfrom
zealsham:fix-core-module-export

Conversation

@zealsham
Copy link
Collaborator

@zealsham zealsham commented Jun 5, 2025

This pull request resolves 688 , by moving reexports to the core module which gives us a cleaner lib.rs file .

This pr also implements the comment by Dan for the core modules.

@zealsham zealsham force-pushed the fix-core-module-export branch 2 times, most recently from 810e60b to 50adab6 Compare June 6, 2025 01:01
@DanGould DanGould requested a review from spacebear21 June 6, 2025 15:50
Copy link
Collaborator

@spacebear21 spacebear21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! There are just two changes that need to be made to remove core from the public API and reduce the diff by making the uri module `pub(crate).

Additionally once you've applied those changes, can you ensure you've run cargo fmt to enforce sorting/grouping of imports?

Lastly, the commit message should be updated to reflect the change as a whole and follow the seven rules (specifically rule 7 in this case).

@zealsham zealsham force-pushed the fix-core-module-export branch from b74a427 to 168eef1 Compare June 11, 2025 01:05
Copy link
Collaborator

@spacebear21 spacebear21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are formatting changes that appear unrelated to the PR. Are you using the nightly rust toolchain (per https://github.com/payjoin/rust-payjoin?tab=readme-ov-file#code-formatting)?

$ rustup default nightly
$ cargo fmt

@DanGould
Copy link
Contributor

@zealsham beware this PR is super useful tech debt payback but the floor is lava because of the SesssionEventLog persister changes; the timing is gonna have to line up really well with the other PRs and it's going to require some periodic rebasing this week

@zealsham
Copy link
Collaborator Author

@spacebear21 yes , it was formated using rustup on nightly build .

@zealsham
Copy link
Collaborator Author

Thanks for the heads-up Dan, I’ll keep an eye on the related PRs and make sure to rebase as needed to keep everything aligned.

@spacebear21
Copy link
Collaborator

yes , it was formated using rustup on nightly build .

Hmm. I don't get those formatting changes if i run cargo fmt locally on the latest master.

I'm on:

❯ rustup default nightly
info: using existing install for 'nightly-aarch64-apple-darwin'
info: default toolchain set to 'nightly-aarch64-apple-darwin'

  nightly-aarch64-apple-darwin unchanged - rustc 1.89.0-nightly (1677d46cb 2025-06-10)

@zealsham
Copy link
Collaborator Author

rustup 1.28.2 (e4f3ad6f8 2025-04-28)
info: This is the version for the rustup toolchain manager, not the rustc compiler.
info: The currently active rustc version is `rustc 1.89.0-nightly (6ccd44760 2025-06-08)

@coveralls
Copy link
Collaborator

coveralls commented Jun 25, 2025

Pull Request Test Coverage Report for Build 15949260878

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.487%

Totals Coverage Status
Change from base Build 15935308780: 0.0%
Covered Lines: 7251
Relevant Lines: 8482

💛 - Coveralls

@zealsham zealsham force-pushed the fix-core-module-export branch from dd2f01c to 1d5a4bf Compare June 27, 2025 00:04
This commit addresses payjoin#688.

Co-authored-by: zealsham <shammahagwor@gmail.com>
@spacebear21 spacebear21 force-pushed the fix-core-module-export branch from 1d5a4bf to 0a7fdca Compare June 28, 2025 23:35
@spacebear21
Copy link
Collaborator

Rebased and removed the unrelated formatting changes.

@spacebear21 spacebear21 dismissed their stale review June 28, 2025 23:36

Rebased and removed the unrelated formatting changes.

Copy link
Collaborator

@spacebear21 spacebear21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0a7fdca

@spacebear21 spacebear21 merged commit 5c1ad3d into payjoin:master Jun 28, 2025
7 checks passed
benalleng added a commit to benalleng/rust-payjoin that referenced this pull request Jul 1, 2025
After payjoin#746 was merged a small path discrepency was created with the core
module now being the direct path to all the src modules. This Pr simply
adds core/ into the path so that cargo mutants has the correct path to
find those modules.
spacebear21 added a commit that referenced this pull request Jul 1, 2025
After #746 was merged a small path discrepancy was created with the core
module now being the direct path to all the src modules. This Pr simply
adds core/ into the path so that cargo mutants has the correct path to
find those modules.
shinghim pushed a commit to shinghim/rust-payjoin that referenced this pull request Jul 2, 2025
After payjoin#746 was merged a small path discrepency was created with the core
module now being the direct path to all the src modules. This Pr simply
adds core/ into the path so that cargo mutants has the correct path to
find those modules.
benalleng added a commit to benalleng/rust-payjoin that referenced this pull request Jul 2, 2025
After payjoin#746 was merged a small path discrepency was created with the core
module now being the direct path to all the src modules. This Pr simply
adds core/ into the path so that cargo mutants has the correct path to
find those modules.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up re-exports

4 participants