Skip to content

Rename RelayState to RelayManager for clarity#727

Merged
DanGould merged 1 commit intopayjoin:masterfrom
0xZaddyy:rename-relay-state
Jun 2, 2025
Merged

Rename RelayState to RelayManager for clarity#727
DanGould merged 1 commit intopayjoin:masterfrom
0xZaddyy:rename-relay-state

Conversation

@0xZaddyy
Copy link
Contributor

@0xZaddyy 0xZaddyy commented Jun 1, 2025

This pull request renames RelayState to RelayManager to better reflect its role in the codebase as a manager rather than just a state holder.

No other changes were made, this PR is focused solely on the renaming.

Closes #724

Copy link
Collaborator

@benalleng benalleng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uTACK thanks this looks good!

Copy link
Contributor

@DanGould DanGould left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4f3655e

ensured no relay_state/RelayState remain

@DanGould DanGould merged commit 538dc31 into payjoin:master Jun 2, 2025
7 checks passed
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 15376703385

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 6 of 8 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.592%

Changes Missing Coverage Covered Lines Changed/Added Lines %
payjoin-cli/src/app/v2/ohttp.rs 3 5 60.0%
Totals Coverage Status
Change from base Build 15354051252: 0.0%
Covered Lines: 6539
Relevant Lines: 7730

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename RelayState to RelayManager in payjoin-cli

4 participants