Seperate v2 cli logic into mod and ohttp components#714
Merged
spacebear21 merged 1 commit intopayjoin:masterfrom May 22, 2025
Merged
Seperate v2 cli logic into mod and ohttp components#714spacebear21 merged 1 commit intopayjoin:masterfrom
spacebear21 merged 1 commit intopayjoin:masterfrom
Conversation
This allows for easier review of the logic in the payjoin-cli as it relates to the v2 relay fallback logic. This change come in before the deprecation and removal of _danger-local-https for even simpler logic here.
Collaborator
Pull Request Test Coverage Report for Build 15188112038Details
💛 - Coveralls |
Collaborator
|
Just a minor nit pik review here Ben, are we in favour of using .clone . I believe that comes with performance overhead , i might be wrong as you're more familiar with the code base than i am. |
Collaborator
IIRC a few of those clones are potentially unnecessary in principle, but technically required because not all arguments are borrowed where possible and instead some are consumed. that seems out of scope for this PR. there is an open issue #402 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for easier review of the logic in the payjoin-cli as it relates to the v2 relay fallback logic.
This change come in before the deprecation and removal of _danger-local-https for even simpler logic here.
This will also help to simplify the diff in #705