Skip to content

Seperate v2 cli logic into mod and ohttp components#714

Merged
spacebear21 merged 1 commit intopayjoin:masterfrom
benalleng:cli-ohttp-separation
May 22, 2025
Merged

Seperate v2 cli logic into mod and ohttp components#714
spacebear21 merged 1 commit intopayjoin:masterfrom
benalleng:cli-ohttp-separation

Conversation

@benalleng
Copy link
Collaborator

@benalleng benalleng commented May 22, 2025

This allows for easier review of the logic in the payjoin-cli as it relates to the v2 relay fallback logic.

This change come in before the deprecation and removal of _danger-local-https for even simpler logic here.

This will also help to simplify the diff in #705

This allows for easier review of the logic in the payjoin-cli as it
relates to the v2 relay fallback logic.

This change come in before the deprecation and removal of
_danger-local-https for even simpler logic here.
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 15188112038

Details

  • 18 of 31 (58.06%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.525%

Changes Missing Coverage Covered Lines Changed/Added Lines %
payjoin-cli/src/app/v2/ohttp.rs 18 31 58.06%
Totals Coverage Status
Change from base Build 15169328807: 0.0%
Covered Lines: 5947
Relevant Lines: 7120

💛 - Coveralls

@zealsham
Copy link
Collaborator

Just a minor nit pik review here Ben, are we in favour of using .clone . I believe that comes with performance overhead , i might be wrong as you're more familiar with the code base than i am.

@nothingmuch
Copy link
Collaborator

Just a minor nit pik review here Ben, are we in favour of using .clone . I believe that comes with performance overhead , i might be wrong as you're more familiar with the code base than i am.

IIRC a few of those clones are potentially unnecessary in principle, but technically required because not all arguments are borrowed where possible and instead some are consumed. that seems out of scope for this PR. there is an open issue #402

Copy link
Collaborator

@nothingmuch nothingmuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Collaborator

@spacebear21 spacebear21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK defa8b5

@spacebear21 spacebear21 merged commit 9da5276 into payjoin:master May 22, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants