Limit visibility of id method for SessionContext to the crate only

[benalleng]

Because SessionContext itself is limited in visibility to the crate this id method should also be limited to crate visibility.

Based on the conversation linked here, #698 (comment)

[coveralls]

Pull Request Test Coverage Report for Build 15187890448

Details

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 83.525%

---

Totals
Change from base Build 15169328807:	0.0%
Covered Lines:	5947
Relevant Lines:	7120

---

💛 - Coveralls

[benalleng]

Is this blocked until we get SessionEvent log because of this?

See BullBitcoin source id() usage. receiver.id() is used to identify the saved thing in the DB downstream until we get SessionEventLog. That's why this is pub.

Seeing as we have now removed the Receiver::id() method as of 67a174d

[DanGould]

i don't think so. receiver.id() is not session_context.id()

[nothingmuch]

utACK

[spacebear21]

ACK