Skip to content

Update some test assertions to compare the invariant vs display string#711

Merged
spacebear21 merged 1 commit intopayjoin:masterfrom
shinghim:707-test
May 22, 2025
Merged

Update some test assertions to compare the invariant vs display string#711
spacebear21 merged 1 commit intopayjoin:masterfrom
shinghim:707-test

Conversation

@shinghim
Copy link
Contributor

Closes #707

@coveralls
Copy link
Collaborator

coveralls commented May 21, 2025

Pull Request Test Coverage Report for Build 15173041899

Details

  • 19 of 19 (100.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 83.465%

Files with Coverage Reduction New Missed Lines %
payjoin/src/send/error.rs 3 38.32%
Totals Coverage Status
Change from base Build 15169328807: -0.06%
Covered Lines: 5936
Relevant Lines: 7112

💛 - Coveralls

@shinghim shinghim marked this pull request as ready for review May 21, 2025 21:39
Copy link
Collaborator

@spacebear21 spacebear21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2b72684

Interestingly, coverage went down slightly because we're no longer covering some Display match arms for those Error variants.

@spacebear21 spacebear21 merged commit 2d69868 into payjoin:master May 22, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update tests to match on invariant rather than display

3 participants