Specify the versions for deps more precisely in the cargo toml#696
Merged
DanGould merged 2 commits intopayjoin:masterfrom May 14, 2025
Merged
Specify the versions for deps more precisely in the cargo toml#696DanGould merged 2 commits intopayjoin:masterfrom
DanGould merged 2 commits intopayjoin:masterfrom
Conversation
We had 2 dep versions that were on lesss specific version numbers and in adding these deps to other crates there is/was some confusion around which version to use. By adding specific versions for these deps when other crates need or want to add these dependecies we can prevent dep tree mismatches.
Collaborator
Pull Request Test Coverage Report for Build 15027169103Details
💛 - Coveralls |
Collaborator
Author
No whoops! |
benalleng
force-pushed
the
toml-version-specify
branch
from
1f305bc to
74d71f9
Compare
DanGould
approved these changes
May 14, 2025
Collaborator
Author
DanGould
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had 2 dependency versions that were on less specific version numbers and in adding these deps to other crates there is/was some confusion around which version to use.
By adding specific versions for these deps when other crates need or want to add these deps we can prevent dep tree mismatches. I am confident that these versions should be pinned as there are several downstream deps that rely on
1.1.0for http and1.19.0for once_cell.These versions are what already exist in the cargo tree and by including these specific versions we are not actually changing any versions, just what devs can refer back to when looking for exact dependency versions.