Skip to content

payjoin-cli: Update README nigiri install instructions#682

Merged
DanGould merged 1 commit intopayjoin:masterfrom
thebrandonlucas:update-payjoin-cli-nigiri-install
May 2, 2025
Merged

payjoin-cli: Update README nigiri install instructions#682
DanGould merged 1 commit intopayjoin:masterfrom
thebrandonlucas:update-payjoin-cli-nigiri-install

Conversation

@thebrandonlucas
Copy link
Collaborator

It appears it is no longer possible to download nigiri via cargo install. This replaces it with the recommended bash script from Github.

Also, my markdown linter made a couple tiny edits (removed the period from the title), and I didn't undo them since I trust the linter knows opinionatedness, but can undo anything if we don't like it.

It appears it is no longer possible to download nigiri via `cargo
install`. This replaces it with the recommended bash script from their
website.
@thebrandonlucas thebrandonlucas requested a review from DanGould May 2, 2025 16:23
@thebrandonlucas thebrandonlucas changed the title payjoin-cli: Update nigiri install instructions payjoin-cli: Update README nigiri install instructions May 2, 2025
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 14799132323

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.057%

Totals Coverage Status
Change from base Build 14760789160: 0.0%
Covered Lines: 5433
Relevant Lines: 6621

💛 - Coveralls

Copy link
Contributor

@DanGould DanGould left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite our use of docker in tests, I am somewhat of a nigiri hater myself. Hope you didn't have to sink too much time on this versus what it'd take to make a flake work.

ACK 21648af

@DanGould DanGould merged commit eb26494 into payjoin:master May 2, 2025
7 checks passed
@thebrandonlucas
Copy link
Collaborator Author

Despite our use of docker in tests, I am somewhat of a nigiri hater myself. Hope you didn't have to sink too much time on this versus what it'd take to make a flake work.

ACK 21648af

@DanGould Little time thankfully, but if that's already where your head is at then yes I'd be happy to explore setting up a nix flake or a docker build for this. Since it seems we make use both nix and docker, I'm not sure which would be more beneficial and aligned with the current state of the project. Biased toward nix as that would allow the binary itself to be installed easily and lighter weight than using docker, but docker is more widely adopted and portable.

Could also pursue both, let me know what you think is best.

Regardless, too many steps currently with nigiri.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants