Skip to content

Dedupe ImplementationError#669

Merged
DanGould merged 1 commit intopayjoin:masterfrom
shinghim:647-dedup
Apr 30, 2025
Merged

Dedupe ImplementationError#669
DanGould merged 1 commit intopayjoin:masterfrom
shinghim:647-dedup

Conversation

@shinghim
Copy link
Contributor

Closes #647

I opted to create a new core module since there isn't a module to put common/core stuff. The new Version enum in #668 could also be put into this mod, among other things

@shinghim shinghim force-pushed the 647-dedup branch 3 times, most recently from eda3230 to 2a756c7 Compare April 27, 2025 20:41
@coveralls
Copy link
Collaborator

coveralls commented Apr 27, 2025

Pull Request Test Coverage Report for Build 14744861695

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 82.057%

Totals Coverage Status
Change from base Build 14713397893: 0.03%
Covered Lines: 5433
Relevant Lines: 6621

💛 - Coveralls

@shinghim shinghim marked this pull request as ready for review April 27, 2025 20:45
Opted for creating a new `core` module that can be used for other
common/core stuff
Copy link
Contributor

@DanGould DanGould left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK c2a3082

Decisive move making the core module. We can start moving a bunch of stuff into it, which will reduce the number of feature gates on src/lib.rs

@DanGould DanGould merged commit a9b461a into payjoin:master Apr 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

De-dup ImplementationError

3 participants