Skip to content

Alter receiver session as_ref assert and persist::Value import for ReceiverToken#658

Merged
DanGould merged 1 commit intopayjoin:masterfrom
benalleng:persist-lint
Apr 17, 2025
Merged

Alter receiver session as_ref assert and persist::Value import for ReceiverToken#658
DanGould merged 1 commit intopayjoin:masterfrom
benalleng:persist-lint

Conversation

@benalleng
Copy link
Collaborator

@benalleng benalleng commented Apr 16, 2025

After moving the as_ref method for the RecieverToken in #638 we needed to change the imports for an assert that prevented a mutant from cropping up. This was missed prior to push and caused some failing lints.

Mutants pass on 6c465dd

@benalleng benalleng marked this pull request as draft April 16, 2025 14:34
@benalleng benalleng changed the title Remove as_ref assert and persist::Value import for ReceiverToken Move import for as_ref assert and persist::Value import for ReceiverToken Apr 16, 2025
@benalleng benalleng changed the title Move import for as_ref assert and persist::Value import for ReceiverToken Alter as_ref assert and persist::Value import for ReceiverToken Apr 16, 2025
@benalleng benalleng marked this pull request as ready for review April 16, 2025 14:45
@benalleng benalleng changed the title Alter as_ref assert and persist::Value import for ReceiverToken Alter receiver session as_ref assert and persist::Value import for ReceiverToken Apr 16, 2025
@benalleng
Copy link
Collaborator Author

@0xBEEFCAF3 this should clear up the lints on your existing PR, I think this is what was causing the failure there as well

After removing the as_ref method for the RecieverToken in payjoin#638 we
needed to modify an assert that prevented a mutant from cropping up.
This was missed prior to push and caused some failing lints.
Copy link
Collaborator

@arminsabouri arminsabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 6c465dd

@arminsabouri
Copy link
Collaborator

@0xBEEFCAF3 this should clear up the lints on your existing PR, I think this is what was causing the failure there as well

Awesome. Thanks for fixing this!

@DanGould DanGould merged commit 3b23dca into payjoin:master Apr 17, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants