Skip to content

Move persist sub module to root module#656

Merged
DanGould merged 1 commit intopayjoin:masterfrom
arminsabouri:mv-persist-submod
Apr 25, 2025
Merged

Move persist sub module to root module#656
DanGould merged 1 commit intopayjoin:masterfrom
arminsabouri:mv-persist-submod

Conversation

@arminsabouri
Copy link
Collaborator

The persist module only contains mod.rs and doesn't need to be a separate submodule.

@arminsabouri
Copy link
Collaborator Author

Thats odd. lint and tests are passing locally. Drafting for now

@arminsabouri arminsabouri marked this pull request as draft April 16, 2025 02:42
@coveralls
Copy link
Collaborator

coveralls commented Apr 24, 2025

Pull Request Test Coverage Report for Build 14668346526

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.936%

Totals Coverage Status
Change from base Build 14668081009: 0.0%
Covered Lines: 5325
Relevant Lines: 6499

💛 - Coveralls

The persist module only contains `mod.rs` and doesn't need to be a
separate submodule.
@arminsabouri arminsabouri marked this pull request as ready for review April 25, 2025 16:05
@arminsabouri arminsabouri requested a review from DanGould April 25, 2025 16:05
Copy link
Contributor

@DanGould DanGould left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6156d6b)

@DanGould DanGould merged commit 64d411c into payjoin:master Apr 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants