Do not log ERROR on directory validation errors#628
Merged
arminsabouri merged 1 commit intopayjoin:masterfrom Apr 9, 2025
Merged
Do not log ERROR on directory validation errors#628arminsabouri merged 1 commit intopayjoin:masterfrom
ERROR on directory validation errors#628arminsabouri merged 1 commit intopayjoin:masterfrom
Conversation
Application validation errors generally shouldn't get log'd as an `ERROR`. The `ERROR` catagory should be reserved for internal server failures. Issue: payjoin#627
arminsabouri
commented
Apr 2, 2025
| const OHTTP_KEY_REJECTION_RES_JSON: &str = r#"{"type":"https://iana.org/assignments/http-problem-types#ohttp-key", "title": "key identifier unknown"}"#; | ||
|
|
||
| error!("Bad request: Key configuration rejected: {}", e); | ||
| warn!("Bad request: Key configuration rejected: {}", e); |
Collaborator
Author
There was a problem hiding this comment.
Should this be ERROR ? Need to dig a bit further to understand when this error would occur
Collaborator
Collaborator
Pull Request Test Coverage Report for Build 14226428979Details
💛 - Coveralls |
DanGould
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Application validation errors generally shouldn't get log'd as an
ERROR. TheERRORcatagory should be reserved for internal server failures.Issue: #627