Make WellKnownError public#598
Merged
spacebear21 merged 2 commits intopayjoin:masterfrom Mar 21, 2025
Merged
Conversation
Collaborator
Pull Request Test Coverage Report for Build 13998660299Details
💛 - Coveralls |
Contributor
|
IMO well known error should be #[non_exhaustive] before it's public. It's unclear whether or not there will be other protocol error variants for fee negotiation |
It's unclear whether or not there will be other protocol error variants for fee negotiation.
Well known errors are required for ffi bindings and should be public
spacebear21
force-pushed
the
pub-well-known-error
branch
from
f8d9591 to
5e871ac
Compare
Collaborator
Author
|
Good point, added. Do you think |
Contributor
|
I can't think of an error that's not well known, unrecognized, or a validation. i don't think ResponseError needs to be non_exhaustive. |
DanGould
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well known errors are required for ffi bindings and should be public