Make serialize_url and extract_v1 infallible

[spacebear21]

I noticed that serialize_url returns a Result<Url, url::ParseError> but never actually returns an Err, so it can simply return a Url instead. The first commit addresses this.

By extension, Sender::extract_v1 no longer needs to return a Result either. The second commit addresses this. However, that one is a breaking change so I can remove this commit if that's undesired.

[coveralls]

Pull Request Test Coverage Report for Build 13845718794

Details

• 14 of 15 (93.33%) changed or added relevant lines in 6 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.04%) to 80.595%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
payjoin-cli/src/app/v2.rs	0	1	0.0%

Files with Coverage Reduction	New Missed Lines	%
payjoin/src/send/mod.rs	2	94.31%

Totals
Change from base Build 13844597959:	-0.04%
Covered Lines:	4826
Relevant Lines:	5988

---

💛 - Coveralls

[benalleng]

Getting rid of the Result here seems to be a nice simplification, I couldn't find anything hidden in serialize_url or extract_v1 that would negate these being made infallible.

I can't speak to whether or not making a breaking change is worth it or not.

[DanGould]

ACK 2b9a6a1

I poked around to make sure the InternalCreateRequestError::Url variant thrown was still being used, and it is, so this all looks good to me.

I'm ok breaking the API, our team faces the biggest burden to make it work in bindings so lets break the API while we still have few dependencies we have capacity to communicate API breaks with.