Handle fetch_ohttp_keys response status#576
Merged
DanGould merged 1 commit intopayjoin:masterfrom Mar 13, 2025
Merged
Conversation
DanGould
force-pushed
the
check-fetch-status
branch
from
ab4f8a2 to
5d28bbc
Compare
Collaborator
Pull Request Test Coverage Report for Build 13843423303Details
💛 - Coveralls |
Collaborator
|
Is this failure unit-testable? |
DanGould
force-pushed
the
check-fetch-status
branch
from
5d28bbc to
41865a1
Compare
Only parse success responses as OhttpKeys. Other responses may be errors to be propagated. These get a new UnexpectedStatusCode error variant. I caught this failure while testing ohttp-relay with an http (not https) proxy, which throws a 400 Bad Request error, but the fetch code only displayed "Invalid ohttp keys returned from payjoin directory"
Contributor
Author
|
added unit tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only parse success responses as OhttpKeys. Other responses may be errors to be propagated.
I caught this failure while testing ohttp-relay with an http (not https) proxy, which throws a 400 Bad Request error, but the fetch code only displayed "Invalid ohttp keys returned from payjoin directory"