Propagate sub-config parsing error#575
Merged
DanGould merged 1 commit intopayjoin:masterfrom Mar 13, 2025
Merged
Conversation
d8acebe to
83c0e75
Compare
For example, if the [v2] field had a pj_directory config field defined, but the URL parsing failed, the error would be swallowed before this change. This now propagates that error to the CLI.
spacebear21
approved these changes
Mar 13, 2025
Collaborator
spacebear21
left a comment
There was a problem hiding this comment.
tACK d17bf0d
Example error message before:
❯ cargo run -- receive 1
Running `/Users/spacebear/Projects/rust-payjoin/target/debug/payjoin-cli receive 1`
Error: V2 configuration is required for BIP77 mode
After:
❯ cargo run -- receive 1
Running `/Users/spacebear/Projects/rust-payjoin/target/debug/payjoin-cli receive 1`
Error: Valid V2 configuration is required for BIP77 mode: missing field `ohttp_relay`
Collaborator
Pull Request Test Coverage Report for Build 13838915414Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example, if the [v2] field had a pj_directory config field defined, but the URL parsing failed, the error would be swallowed before this change.
This now propagates that error to the CLI.
The error propagation still isn't perfect, and some config errors get swallowed without complete context, but this is progress.