Skip to content

Fix confusing and incorrect test condition #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nothingmuch merged 2 commits into from
Mar 12, 2025
Merged

Fix confusing and incorrect test condition #571

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bef64b
Fix confusing and incorrect test condition
nothingmuch Mar 12, 2025
0f7b9e5
Remove polling delay from test
nothingmuch Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions payjoin/tests/integration.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,25 +486,25 @@ mod integration {
let mock_ohttp_relay = services.ohttp_gateway_url();
let receiver_loop = tokio::task::spawn(async move {
let agent_clone = agent_clone.clone();
let (response, ctx) = loop {
let proposal = loop {
let (req, ctx) = session.extract_req(&mock_ohttp_relay)?;
let response = agent_clone.post(req.url).body(req.body).send().await?;

if response.status() == 200 {
break (response.bytes().await?.to_vec(), ctx);
} else if response.status() == 202 {
log::info!(
"No response yet for POST payjoin request, retrying some seconds"
);
tokio::time::sleep(std::time::Duration::from_secs(1)).await;
if let Some(proposal) = session
.process_res(response.bytes().await?.to_vec().as_slice(), ctx)?
{
break proposal;
} else {
log::info!(
"No response yet for POST payjoin request, retrying some seconds"
);
}
} else {
log::error!("Unexpected response status: {}", response.status());
panic!("Unexpected response status: {}", response.status())
}
};
let proposal = session
.process_res(response.as_slice(), ctx)?
.expect("proposal should exist");
let mut payjoin_proposal =
handle_directory_proposal(&receiver_clone, proposal, None)
.map_err(|e| e.to_string())?;
Expand Down
Loading