Check independent features

[DanGould]

I noticed when reviewing #558 that some intended feature combinations were broken. In particular tests didn't catch that a v2 feature gate on an error variant would break if the impl Display for that variant wasn't also gated. This led me to notice that cargo check --no-default-features --features v1 was also failing because of unavailability of thread_rng.

The first commit addresses the build failure in independent v1 build, the second creates checks for payjoin.

I am curious if @spacebear21 you think such checks are also appropriate for payjoin-cli and payjoin-directory who should be able to be compiled with independent feature combinations as well. I chose check as a happy medium tradeoff between redundant tests and independent feature combination failure. I believe with careful review this CI job should catch the vast majority of potential mistakes.

close #566

[coveralls]

Pull Request Test Coverage Report for Build 13815084700

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 43 unchanged lines in 3 files lost coverage.
• Overall coverage increased (+0.03%) to 79.738%

---

Files with Coverage Reduction	New Missed Lines	%
payjoin-test-utils/src/lib.rs	4	97.06%
payjoin/src/io.rs	12	34.04%
payjoin-directory/src/lib.rs	27	77.64%

Totals
Change from base Build 13725031512:	0.03%
Covered Lines:	4569
Relevant Lines:	5730

---

💛 - Coveralls

[spacebear21]

if such checks are also appropriate for payjoin-cli and payjoin-directory who should be able to be compiled with independent feature combinations as well

Yes, the CI overhead of cargo check seems low enough that I don't see a good reason not to.

Actually I wonder if we should make this check a part of lint.sh and just run cargo clippy for each independent feature? That way we also get the benefit of flagging e.g. unused code warnings.

[DanGould]

I see no obvious reason not to cargo clippy instead. Will rework to do that.

[DanGould]

Updated to use cargo clippy and include payjoin-cli independent features to get the benefit of unused code warnings as well. This replaces cargo check but leaves it in the history to document the rationale.

[benalleng]

tACK. Tested both from the main repo dir and observed the independent feature lints for payjoin and payjoin-cli as well tested within each crate

[spacebear21]

ACK be60b68

[spacebear21]

Did you leave out payjoin-directory intentionally?

[DanGould]

I did leave out payjoin-directory and payjoin-test-utils intentionally. They're included in the top level lint cargo clippy --all-targets --keep-going --all-features -- -D warnings and don't require independent feature checks as far as I understand.