Skip to content

Code spell#562

Merged
DanGould merged 2 commits intopayjoin:masterfrom
arminsabouri:code-spell
Mar 4, 2025
Merged

Code spell#562
DanGould merged 2 commits intopayjoin:masterfrom
arminsabouri:code-spell

Conversation

@arminsabouri
Copy link
Collaborator

@arminsabouri arminsabouri commented Mar 4, 2025 •
edited by DanGould
Loading

close #561

@arminsabouri
Fix repo wide selling errors
529deeb 
These fixes were auto generated via `codespell -w .` with the following
codespell config

```
[codespell]
skip = .git,target,Cargo.toml,Cargo.lock,Cargo-minimal.lock,Cargo-recent.lock
ignore-words-list = crate,ser
```

Issue: payjoin#561
@coveralls
Copy link
Collaborator

coveralls commented Mar 4, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13658213680

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.725%
Totals Coverage Status
Change from base Build 13637705402: 0.0%
Covered Lines: 4530
Relevant Lines: 5682
💛 - Coveralls

@arminsabouri arminsabouri marked this pull request as draft March 4, 2025 15:38
@arminsabouri
Run codespell on CI
16c99ec 
This commit introduces a codespell config skipping over non-code files
and a CI job running codespell using the config.
Issue: payjoin#561
@arminsabouri arminsabouri marked this pull request as ready for review March 4, 2025 16:34
@benalleng
Copy link
Collaborator

benalleng commented Mar 4, 2025

Ooh love this I m terible spellur

benalleng
benalleng reviewed Mar 4, 2025
View reviewed changes
.codespellrc
@@ -0,0 +1,3 @@
[codespell]
skip = .git,target,Cargo.toml,Cargo.lock,Cargo-minimal.lock,Cargo-recent.lock
ignore-words-list = crate,ser
Copy link
Collaborator

@benalleng benalleng Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it think crate is not a word?

Copy link
Collaborator Author

@arminsabouri arminsabouri Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this was really confusing. But "crate" is not in its dictionary. It tries to auto correct to "create".

spacebear21
spacebear21 approved these changes Mar 4, 2025
View reviewed changes
Copy link
Collaborator

@spacebear21 spacebear21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 16c99ec

DanGould
DanGould approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@DanGould DanGould left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 16c99ec

I like that this lives outside of the ./lint.sh script, and changes are easy enough to address yourself without the dep. As long as this CI action isn't a bottleneck it's a net positive.

@DanGould DanGould merged commit df30f3b into payjoin:master Mar 4, 2025
7 checks passed
@DanGould DanGould mentioned this pull request Mar 4, 2025
Closed
@arminsabouri arminsabouri deleted the code-spell branch March 4, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benalleng benalleng benalleng left review comments

@DanGould DanGould DanGould approved these changes

@spacebear21 spacebear21 spacebear21 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Codespell

5 participants

@arminsabouri @coveralls @benalleng @DanGould @spacebear21