don't accept invalid certs even in tests#550
Merged
DanGould merged 1 commit intopayjoin:masterfrom Feb 21, 2025
Merged
Conversation
Collaborator
Pull Request Test Coverage Report for Build 13466665336Details
💛 - Coveralls |
nothingmuch
force-pushed
the
no-accept-invalid-certs
branch
from
81fec37 to
edb595e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor cleanup change from the WIP self signed certificates that can be merged independently.
Turns out we're actually not (no longer?) relying on invalid certificates because the
with_certfunctionality just asserts that the self signed certificate, which is its own root, is valid.