Skip to content

Remove map_errs for ImplementationError#536

Merged
spacebear21 merged 1 commit intopayjoin:masterfrom
spacebear21:remove-unnecessary-map-errs
Feb 13, 2025
Merged

Remove map_errs for ImplementationError#536
spacebear21 merged 1 commit intopayjoin:masterfrom
spacebear21:remove-unnecessary-map-errs

Conversation

@spacebear21
Copy link
Collaborator

@spacebear21 spacebear21 commented Feb 13, 2025

ImplementationErr is a Box<dyn Error...> so most error types can just be coerced implicitly with the ? operator.

@spacebear21 spacebear21 requested a review from DanGould February 13, 2025 15:34
ImplementationErr is a Box<dyn Error...> so most error types can just be
coerced with the implicitly `?` operator.
@spacebear21 spacebear21 force-pushed the remove-unnecessary-map-errs branch from d766b98 to 47c73df Compare February 13, 2025 15:40
@spacebear21
Copy link
Collaborator Author

Coverage check is failing because Coveralls is down for planned maintenance.

Copy link
Contributor

@DanGould DanGould left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice big fat delete 😎

ack 47c73df

@spacebear21 spacebear21 merged commit 2627ef2 into payjoin:master Feb 13, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants