Abstract away additionalfeecontribution to its own struct#521
Merged
DanGould merged 1 commit intopayjoin:masterfrom Feb 1, 2025
Merged
Conversation
Collaborator
Pull Request Test Coverage Report for Build 13078047990Details
💛 - Coveralls |
DanGould
requested changes
Jan 31, 2025
Contributor
DanGould
left a comment
DanGould
left a comment
There was a problem hiding this comment.
Clean. I don't think it should be part of the pub API. No requests other than changing it to private or otherwise clarifying API visibility.
payjoin/src/send/mod.rs
Outdated
|
|
||
| #[derive(Debug, Clone, Copy, PartialEq, Eq)] | ||
| #[cfg_attr(feature = "v2", derive(serde::Serialize, serde::Deserialize))] | ||
| pub struct AdditionalFeeContribution { |
Contributor
There was a problem hiding this comment.
Is there any good reason for this to be pub?
Collaborator
Author
There was a problem hiding this comment.
Nope. Thanks for catching that. Switched to pub(crate)
arminsabouri
force-pushed
the
arm/additionfeecontribution-abstraction
branch
from
c149c3b to
aa22001
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tuple was somewhat confusing, and I often forget what each value represents. Organizing this data into a struct makes it more intuitive and easier to work with.
Cherry-pick'd off #434