Validate_utxo treats missing utxos as an error#516
Merged
DanGould merged 1 commit intopayjoin:masterfrom Jan 28, 2025
Merged
Conversation
missing utxo information should always be treated as an error not just when a boolean flag is set this flag was also always set to true in the codebase so it seems useless
Collaborator
Pull Request Test Coverage Report for Build 13016693385Details
💛 - Coveralls |
DanGould
approved these changes
Jan 28, 2025
Contributor
DanGould
left a comment
There was a problem hiding this comment.
tACK a66f00c 🚀
This is the way to MOVE!
Next commit, I'm going to be more anal about the commit message. I'd like to see
- imperative mood in the first line
- Capitalization
- Punctuation in subsequent lines
Always treat missing utxo as
validate_utxoerrorMissing utxo information should always be treated as an error, not just when a boolean flag is set.
This flag was also always set to true in the codebase so it seems useless.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing utxo information should always be treated as an error, the flag we had also was always set to true so its seems not helpful to create a function arg to always be set to true.
This Pr is practice to figure out if I am doing commit messages and commit tests correctly