Skip to content

Validate_utxo treats missing utxos as an error#516

Merged
DanGould merged 1 commit intopayjoin:masterfrom
benalleng:treat-missing-utxo-as-error
Jan 28, 2025
Merged

Validate_utxo treats missing utxos as an error#516
DanGould merged 1 commit intopayjoin:masterfrom
benalleng:treat-missing-utxo-as-error

Conversation

@benalleng
Copy link
Collaborator

@benalleng benalleng commented Jan 28, 2025

Missing utxo information should always be treated as an error, the flag we had also was always set to true so its seems not helpful to create a function arg to always be set to true.

This Pr is practice to figure out if I am doing commit messages and commit tests correctly

missing utxo information should always be treated as an error not just when a boolean flag is set
this flag was also always set to true in the codebase so it seems useless
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 13016693385

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 78.496%

Files with Coverage Reduction New Missed Lines %
payjoin/src/send/mod.rs 2 93.79%
Totals Coverage Status
Change from base Build 12968704432: -0.03%
Covered Lines: 3643
Relevant Lines: 4641

💛 - Coveralls

Copy link
Contributor

@DanGould DanGould left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK a66f00c 🚀

This is the way to MOVE!


Next commit, I'm going to be more anal about the commit message. I'd like to see

  • imperative mood in the first line
  • Capitalization
  • Punctuation in subsequent lines

Always treat missing utxo as validate_utxo error

Missing utxo information should always be treated as an error, not just when a boolean flag is set.
This flag was also always set to true in the codebase so it seems useless.

@DanGould DanGould merged commit 7888a2c into payjoin:master Jan 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants