Add cargo llvm-cov to flake devshell#495
Merged
DanGould merged 1 commit intopayjoin:masterfrom Jan 24, 2025
Merged
Conversation
Collaborator
Pull Request Test Coverage Report for Build 12938871114Details
💛 - Coveralls |
DanGould
reviewed
Jan 20, 2025
Contributor
DanGould
left a comment
There was a problem hiding this comment.
When I tried to test output says cargo-llvm-cov-0.6.14 is marked as broken. is that OK?
Details
payjoin % nix develop
error:
… while calling the 'derivationStrict' builtin
at /builtin/derivation.nix:9:12: (source not available)
… while evaluating derivation 'nix-shell'
whose name attribute is located at /nix/store/8vz84mqgnm1gz5yk7hgnnb5gir5hjxas-source/pkgs/stdenv/generic/make-derivation.nix:375:7
… while evaluating attribute 'nativeBuildInputs' of derivation 'nix-shell'
at /nix/store/8vz84mqgnm1gz5yk7hgnnb5gir5hjxas-source/pkgs/stdenv/generic/make-derivation.nix:419:7:
418| depsBuildBuild = elemAt (elemAt dependencies 0) 0;
419| nativeBuildInputs = elemAt (elemAt dependencies 0) 1;
| ^
420| depsBuildTarget = elemAt (elemAt dependencies 0) 2;
error: Package ‘cargo-llvm-cov-0.6.14’ in /nix/store/8vz84mqgnm1gz5yk7hgnnb5gir5hjxas-source/pkgs/by-name/ca/cargo-llvm-cov/package.nix:85 is marked as broken, refusing to evaluate.
a) To temporarily allow broken packages, you can use an environment variable
for a single invocation of the nix tools.
$ export NIXPKGS_ALLOW_BROKEN=1
Note: When using `nix shell`, `nix build`, `nix develop`, etc with a flake,
then pass `--impure` in order to allow use of environment variables.
b) For `nixos-rebuild` you can set
{ nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.
c) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
{ allowBroken = true; }
to ~/.config/nixpkgs/config.nix.
Collaborator
Author
|
see NixOS/nixpkgs#351574 and its discussion i guess we can make it conditional, and skip it on mac |
Contributor
|
optional and omitted on mac is a workable solution |
Contributor
|
See how optional compilation is configured in mutiny-node's flake |
c1d4dec to
5654ea8
Compare
Collaborator
Author
|
i only added the optionality to the cargo-llvm-cov package (not the associated rust toolchain component), and tested that the devshell is no longer broken on a mac |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.