Avoid stringly typed arguments in payjoin-cli App trait#479
Merged
DanGould merged 2 commits intopayjoin:masterfrom Jan 14, 2025
Merged
Avoid stringly typed arguments in payjoin-cli App trait#479DanGould merged 2 commits intopayjoin:masterfrom
DanGould merged 2 commits intopayjoin:masterfrom
Conversation
Collaborator
Pull Request Test Coverage Report for Build 12767588652Details
💛 - Coveralls |
DanGould
approved these changes
Jan 14, 2025
Contributor
There was a problem hiding this comment.
tACK 7c53399. I smoke tested and checked that FeeRate and Amount sent were appropriate, because I don't think these are tested in e2e.rs.
I agree with implicit units with explicit documentation.
This marks progress toward #452 but does not yet complete it because receiver's max_fee_rate is still an Option<u64> but not a proper Option<FeeRate>
Collaborator
Author
Indeed, I did these more than a week ago, and wanted to PR before I forgot, in hindsight I should have reviewed the issue before opening this PR. I will follow up since that's probably also a very simple change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor standalone changes from ongoing refactoring work. A more comprehensive approach might be to allow explicit units to be parsed from the string form of these arguments (see also rust-bitcoin/rust-bitcoin#1786) but personally I think that's undesirable since it complicates payjoin-cli, and as a reference implementation it should prioritize readability and simplicity over convenience/flexibility of the CLI.