Join subdir to base pj URL to preserve path#448
Merged
DanGould merged 1 commit intopayjoin:masterfrom Dec 29, 2024
Merged
Conversation
DanGould
force-pushed
the
dont-set-path
branch
from
b5ba0df to
4ff1bef
Compare
Collaborator
Pull Request Test Coverage Report for Build 12537468509Details
💛 - Coveralls |
DanGould
force-pushed
the
dont-set-path
branch
from
4ff1bef to
df9c5b8
Compare
Fix payjoin#416 Without this change a base URL subpath e.g. https://payjo.in/dir-path/ would be overwritten when V2GetContext.extract_req was called and incorrectly produce a request to https://payjo.in/subdir instead of https://payjo.in/dir-path/subdir.
nothingmuch
approved these changes
Dec 29, 2024
Collaborator
There was a problem hiding this comment.
ACK re code changes.
In regards verifying fully resolves the issue, did you do the hacky manual testing we discussed of the directory to ensure end to end flow works, or verify that all instances of setting subdirectory ID consistently use join now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #416
Without this change a base URL subpath e.g. https://payjo.in/dir-path/ would be overwritten when V2GetContext.extract_req was called and incorrectly produce a request to https://payjo.in/subdir instead of https://payjo.in/dir-path/subdir.
--
This was smoke test by setting
let base_url let base_url = self.endpoint.clone().join("gg/")and ensuring thelet url = base_url.join(&subdir.to_string()) .map_err(InternalCreateRequestError::Url)?;preserved the path and resulted in "https://example.com/gg/"