Skip to content

Fix fragment parameter case sensitivity #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DanGould wants to merge 1 commit into from
Closed

Fix fragment parameter case sensitivity #446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions payjoin/src/uri/url_ext.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,18 +97,19 @@ impl UrlExt for Url {
}
}

/// Get a parameter from the URL fragment
///
/// This function is case insensitive
fn get_param<F, T>(url: &Url, prefix: &str, parse: F) -> Option<T>
where
F: Fn(&str) -> Option<T>,
{
if let Some(fragment) = url.fragment() {
for param in fragment.split('+') {
if param.starts_with(prefix) {
return parse(param);
}
}
}
None
let prefix = prefix.to_uppercase();
url.fragment()?
.to_uppercase()
.split('+')
.find(|param| param[..prefix.len()] == prefix)
.and_then(parse)
}

fn set_param(url: &mut Url, prefix: &str, param: &str) {
Expand Down
Loading