Merged
Conversation
34d2b4f to
efbf7df
Compare
Collaborator
Pull Request Test Coverage Report for Build 12132229311Details
💛 - Coveralls |
efbf7df to
858f76a
Compare
858f76a to
9d937bc
Compare
Contributor
Author
|
@nothingmuch I think we made it. I don't think we need an rc unless we need test utils in this one. what say you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should really get #417, #373,
and perhaps #413in before release candidate in order to prevent future breaking changes