Merged
Conversation
This uses the path supplied `bash`, and will also allow the scripts to run on NixOS where `/usr/bin/env` is shimmed for compatibility but `/bin/bash` can't be relied on.
DanGould
added a commit
that referenced
this pull request
Jan 4, 2025
seems that i missed this one in #384
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit makes it possible to run the test scripts on a NixOS host assuming
cargoetc are in the current environment. In order forbitcoindto to be usable on NixOS (e2e and integration tests), the machine configuration needsprograms.nix-ld.enable = trueset as well.The second commit consistently uses set -e to exit on failure in all scripts.
The third commit appeases unix editors and git by terminating the last line with a \n.