Move common boilerplate in integration module#348
Merged
DanGould merged 1 commit intopayjoin:masterfrom Aug 19, 2024
Merged
Conversation
DanGould
approved these changes
Aug 19, 2024
| ) -> Result<Psbt, BoxError> { | ||
| let mut outputs = HashMap::with_capacity(1); | ||
| outputs.insert(pj_uri.address.to_string(), pj_uri.amount.unwrap()); | ||
| debug!("outputs: {:?}", outputs); |
Contributor
There was a problem hiding this comment.
This debug! got deleted but that's ok with me
| let payjoin_psbt = sender.wallet_process_psbt(&psbt.to_string(), None, None, None)?.psbt; | ||
| let payjoin_psbt = sender.finalize_psbt(&payjoin_psbt, Some(false))?.psbt.unwrap(); | ||
| let payjoin_psbt = Psbt::from_str(&payjoin_psbt)?; | ||
| tracing::debug!("Sender's Payjoin PSBT: {:#?}", payjoin_psbt); |
Contributor
There was a problem hiding this comment.
we've mixed tracing::debug! and log::debug! in this file which could be unified in a later optimization. No need to stall this huge payoff of tech debt for further optimizations though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cut down on duplicate testing fixtures.