Sort session events by auto-incrementing id#1202
Merged
arminsabouri merged 1 commit intopayjoin:masterfrom Nov 24, 2025
Merged
Conversation
Events may share the same `created_at` timestamp if they were created in the same second. An out of sync system time could also lead to inconsistent sorting -- which would eventually cause a panic when replaying the session. Co-authored-by: Mshehu5 <musheu@gmail.com>
arminsabouri
force-pushed
the
sort-events-by-id
branch
from
25bde69 to
78214b6
Compare
Collaborator
Pull Request Test Coverage Report for Build 19643947073Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Events may share the same
created_attimestamp if they were created in the same second. An out of sync system time could also lead to inconsistent sorting -- which would eventually cause a panic when replaying the session.cherry picked from #1158
Closes: #1201
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.