Remove public /metrics endpoint from directory#1178
Merged
spacebear21 merged 1 commit intopayjoin:masterfrom Oct 27, 2025
Merged
Remove public /metrics endpoint from directory#1178spacebear21 merged 1 commit intopayjoin:masterfrom
spacebear21 merged 1 commit intopayjoin:masterfrom
Conversation
Metrics collection is typically done on a private network address rather than one that is exposed to open internet. This removes the public /metrics endpoint and serves metrics requests separately on the --metrics-port if one was provided.
Collaborator
Pull Request Test Coverage Report for Build 18787026556Details
💛 - Coveralls |
Collaborator
|
ACK |
Contributor
|
cACK |
zealsham
reviewed
Nov 2, 2025
| _ => not_found(), | ||
| }; | ||
|
|
||
| Ok(response) |
Collaborator
There was a problem hiding this comment.
should we serve this at "/" metrics rather than "/"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1174
Metrics collection is typically done on a private network address rather than one that is exposed to open internet. This removes the public /metrics endpoint and serves metrics requests separately on the --metrics-port if one was provided.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.