Merged
Conversation
The metrics server was previously blocking, which prevented the directory from ever being served. This spawns the metrics server in a background task, allowing the main server to continue starting.
Increment connection count when `serve_connection` is called. Previously this was only done in `serve_tls` which doesn't record production usage.
Collaborator
Pull Request Test Coverage Report for Build 18760791093Details
💛 - Coveralls |
Contributor
|
I assume the second commit isn't duplicate per se, it's just a different code path. Might you confirm? |
Collaborator
Author
|
yes, |
DanGould
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.