Fix identify_receiver_outputs#1168
Merged
spacebear21 merged 2 commits intopayjoin:masterfrom Oct 21, 2025
Merged
Conversation
The receiver should ignore the additional fee contribution param specified by the sender, if the specified fee output index is owned by the receiver. `identify_receiver_outputs` previously modified a cloned version of `params` but didn't do anything with the result.
Collaborator
Pull Request Test Coverage Report for Build 18691661780Details
💛 - Coveralls |
benalleng
reviewed
Oct 21, 2025
|
|
||
| pub fn identify_receiver_outputs( | ||
| &self, | ||
| self, |
Collaborator
There was a problem hiding this comment.
Why is this self changed to no longer be a ref in this commit as opposed to in b8b2a42?
Collaborator
Author
There was a problem hiding this comment.
No good reason tbh, I just realized it should consume self while writing the test.
Collaborator
There was a problem hiding this comment.
Ok, thats fine I just wanted to make sure it wouldn't be a git bisect problem.
benalleng
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the linting error #1162 , which incidentally was an actual bug in the implementation since the updated params were ignored.
Supersedes #1163.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.