Use full_relay_url in sender GET request#1166
Merged
spacebear21 merged 2 commits intopayjoin:masterfrom Oct 21, 2025
Merged
Conversation
The directory URL must be included in the path but was previously only included in POST requests (introduced in 8906c76). This includes it in GET requests as well.
Collaborator
Pull Request Test Coverage Report for Build 18670427278Details
💛 - Coveralls |
This simplifies the extract_request() function signature and reduces duplication.
DanGould
approved these changes
Oct 21, 2025
Contributor
DanGould
left a comment
There was a problem hiding this comment.
ACK f724e42
Great find. That directory 1-1 GATEWAY_URL backwards compatibility is gonna need to get removed once Bull Bitcoin Mobile and Cake upgrade. I do wonder if it makes more sense to enforce in the Request::new_v2 rather than the fn full_relay_url
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue with directories other than the GATEWAY_ORIGIN specified by the OHTTP relay. Previously, attempting to use a different directory using the gateway opt-in mechanism resulted in an error due to the ohttp relay routing the sender request to the wrong directory:
The directory URL must be included in the path but was previously only included in POST requests (introduced in 8906c76). This includes it in GET requests as well.
I used Sonnet 4.5 for troubleshooting.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.