Assert reply_key for RetrievedOriginalPayload#1152
Merged
spacebear21 merged 1 commit intopayjoin:masterfrom Oct 6, 2025
Merged
Assert reply_key for RetrievedOriginalPayload#1152spacebear21 merged 1 commit intopayjoin:masterfrom
spacebear21 merged 1 commit intopayjoin:masterfrom
Conversation
Collaborator
Pull Request Test Coverage Report for Build 18288262677Details
💛 - Coveralls |
spacebear21
reviewed
Oct 6, 2025
| reply_key: reply_key.clone(), | ||
| }); | ||
| assert_eq!( | ||
| SessionHistory { events: events.clone() }.session_context().reply_key, |
Collaborator
There was a problem hiding this comment.
Suggested change
| SessionHistory { events: events.clone() }.session_context().reply_key, | |
| SessionHistory::new(events.clone()).session_context().reply_key, |
spacebear21
reviewed
Oct 6, 2025
Collaborator
spacebear21
left a comment
There was a problem hiding this comment.
I wonder if it might be less hacky to test for the presence of the reply_key in run_session_history_test? It's a bit of a special case because it's session_context() is a private function but if the goal is to assert that a reply_key is present on sessions that retrieved the original payload I feel like the tests should be more systematic about that.
Fixes the mutant in payjoin#1151
35270ad to
2bb3e72
Compare
Collaborator
Author
|
Ok, thats fair, I just created a match block in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the mutant in #1151
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.