Return closed session state during replays#1136
Merged
arminsabouri merged 1 commit intopayjoin:masterfrom Oct 2, 2025
Merged
Conversation
arminsabouri
force-pushed
the
ressurect-terminal-failure
branch
2 times, most recently
from
db66aad to
245ae09
Compare
arminsabouri
changed the title
Collaborator
Pull Request Test Coverage Report for Build 18202314393Details
💛 - Coveralls |
spacebear21
reviewed
Oct 2, 2025
payjoin/src/core/receive/v2/mod.rs
Outdated
| ReceiveSession::PayjoinProposal(r) => r.session_context, | ||
| ReceiveSession::HasReplyableError(r) => r.session_context, | ||
| ReceiveSession::Monitor(r) => r.session_context, | ||
| ReceiveSession::Closed(_) => unreachable!(), |
Collaborator
There was a problem hiding this comment.
Maybe this should just return ReceiveSession::Closed(outcome)? In this case it doesn't hurt to return the same state since nothing can be done with it.
Collaborator
Author
There was a problem hiding this comment.
Makes sense. Done
We want to avoid returning the current state if a closed event was processed from the log. The application may just perform the event that caused the error instead of treating the session as terminally closed.
arminsabouri
force-pushed
the
ressurect-terminal-failure
branch
from
245ae09 to
8f03b4c
Compare
spacebear21
approved these changes
Oct 2, 2025
Collaborator
spacebear21
left a comment
spacebear21
left a comment
There was a problem hiding this comment.
approach ACK + code ACK 8f03b4c
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to avoid returning the current state if a closed event was
processed from the log. The application may just perform the event that
caused the error instead of treating the session as terminally closed.
An alternative approach to #1132
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.
AI disclosure: Cursor autocomplete used