Depend on url/serde with no default features#1126
Merged
Conversation
IDNA is huge ball of complexity that some of our targets, namely Block applications, don't want to depend on. This isn't a full #1124 removal but it's a one line change that gets rid of the biggest offenders. I probably need to update the lock files too.
Collaborator
Pull Request Test Coverage Report for Build 18140675050Details
💛 - Coveralls |
Contributor
Author
|
@benalleng Looks like we still have the `cargo tree` |
Collaborator
|
Hmm odd that it is in our tree even though we don't have the http feature enabled for bhttp. I think this is coming from |
Contributor
Author
it's from bhttp if you look at the cargo tree summary |
Collaborator
|
Yeah but its enabled through that dep:http I think as bhttp does not have url as a default dependency |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IDNA is huge ball of complexity that some of our targets, namely Block applications, don't want to depend on. This isn't a full #1124 removal but it's a one line change that gets rid of the biggest offenders.
I probably need to update the lock files too.nope, it works.Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR. (none)