Skip to content

Depend on url/serde with no default features#1126

Merged
DanGould merged 1 commit intomasterfrom
url-no-idna
Sep 30, 2025
Merged

Depend on url/serde with no default features#1126
DanGould merged 1 commit intomasterfrom
url-no-idna

Conversation

@DanGould
Copy link
Contributor

@DanGould DanGould commented Sep 30, 2025

IDNA is huge ball of complexity that some of our targets, namely Block applications, don't want to depend on. This isn't a full #1124 removal but it's a one line change that gets rid of the biggest offenders.

I probably need to update the lock files too. nope, it works.

Pull Request Checklist

Please confirm the following before requesting review:

IDNA is huge ball of complexity that some of our targets, namely Block applications, don't want to depend on. This isn't a full #1124 removal but it's a one line change that gets rid of the biggest offenders.

I probably need to update the lock files too.
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 18140675050

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.647%

Totals Coverage Status
Change from base Build 18138517774: 0.0%
Covered Lines: 8601
Relevant Lines: 10161

💛 - Coveralls

@DanGould DanGould requested a review from benalleng September 30, 2025 19:20
@DanGould DanGould marked this pull request as ready for review September 30, 2025 19:20
@DanGould
Copy link
Contributor Author

@benalleng Looks like we still have the url/idna dependency from bhttp. Doesn't need to block this but should be related to #1124 as a first step

`cargo tree`
payjoin v0.24.0 (/Users/dan/f/dev/payjoin/payjoin)
├── bhttp v0.6.1
│   ├── thiserror v1.0.63
│   │   └── thiserror-impl v1.0.63 (proc-macro)
│   │       ├── proc-macro2 v1.0.101
│   │       │   └── unicode-ident v1.0.12
│   │       ├── quote v1.0.40
│   │       │   └── proc-macro2 v1.0.101 (*)
│   │       └── syn v2.0.106
│   │           ├── proc-macro2 v1.0.101 (*)
│   │           ├── quote v1.0.40 (*)
│   │           └── unicode-ident v1.0.12
│   └── url v2.5.7
│       ├── form_urlencoded v1.2.2
│       │   └── percent-encoding v2.3.2
│       ├── idna v1.1.0

@benalleng
Copy link
Collaborator

benalleng commented Sep 30, 2025

Hmm odd that it is in our tree even though we don't have the http feature enabled for bhttp.

I think this is coming from dep:http in the payjoin _core feature

Copy link
Collaborator

@benalleng benalleng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack on 502b6ee one more step to getting rid of it entirely

@DanGould DanGould merged commit 4662cd5 into master Sep 30, 2025
20 checks passed
@DanGould
Copy link
Contributor Author

I think this is coming from dep:http in the payjoin _core feature

it's from bhttp if you look at the cargo tree summary

@benalleng
Copy link
Collaborator

Yeah but its enabled through that dep:http I think as bhttp does not have url as a default dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants