Use String type instead of Url on Request Struct#1122
Merged
spacebear21 merged 1 commit intopayjoin:masterfrom Sep 30, 2025
Merged
Use String type instead of Url on Request Struct#1122spacebear21 merged 1 commit intopayjoin:masterfrom
spacebear21 merged 1 commit intopayjoin:masterfrom
Conversation
This approach removes url::Url from the public API by chaging the url field type to a String allowing us to not need to change the visibility of the internal fields on the Request Struct.
Collaborator
Pull Request Test Coverage Report for Build 18113897365Details
💛 - Coveralls |
DanGould
approved these changes
Sep 30, 2025
Contributor
DanGould
left a comment
DanGould
left a comment
There was a problem hiding this comment.
This is a lot simpler. Seems like the way to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This approach removes url::Url from the public API by chaging the url field type to a String allowing us to not need to change the visibility of the internal fields on the Request Struct.
This is an alternate approach to close #513 and if we like it sill supercede #1121
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.